chore: change useUserContext to useEnvData
#901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RenderOptions should be updated too, it still has userContext there |
|
@manucorporat done! |
|
looking great! lets wait for the CI to pass and merge it |
|
@manucorporat for some reason the E2E tests are failing on using the older version is it a "dog fooding" kind of issue? |
|
This breaking change is tricky, because it's self referenced, qwikcity needs a version that is not released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Following our discussion, we decided that
useEnvDatais a more descriptive name thanuseUserContextand might cause less confusions in the future.This is a BREAKING CHANGE (why am I yelling? 😅)
but for an undocumented api which only qwik city uses at the moment
Checklist: