Skip to content

fix: qwik-city entry chunk name #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2022
Merged

fix: qwik-city entry chunk name #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/qwik-city/buildtime/routing/resolve-source-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,7 @@ export function resolveError(

function resolveEntry(opts: NormalizedPluginOptions, sourceFile: RouteSourceFile) {
const pathname = getPathnameFromDirPath(opts, sourceFile.dirPath);

const entryTextIndex = pathname.lastIndexOf('/entry');
const chunkFileName = pathname.slice(1, entryTextIndex) + '.js';
const chunkFileName = pathname.slice(1);

const buildEntry: BuildEntry = {
id: createFileId(opts.routesDir, sourceFile.filePath),
Expand Down
2 changes: 1 addition & 1 deletion packages/qwik-city/buildtime/runtime-generation/entries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export function generateQwikCityEntries(ctx: BuildContext) {
c.push(`\n/** Qwik City Entries (${ctx.entries.length}) */`);
for (let i = 0; i < ctx.entries.length; i++) {
const entry = ctx.entries[i];
c.push(`export const _${i} = () => import(${JSON.stringify(entry.filePath)});`);
c.push(`export const ${entry.id} = () => import(${JSON.stringify(entry.filePath)});`);

Check warning

Code scanning / CodeQL

Improper code sanitization

[Improperly sanitized value](1) flows to here and is used to construct code.
}

return c.join('\n') + '\n';
Expand Down