Skip to content

Add simulatePedigrees() for simulating multiple families in one call#150

Open
Copilot wants to merge 9 commits intodev_mainfrom
copilot/feature-simulate-multiple-families
Open

Add simulatePedigrees() for simulating multiple families in one call#150
Copilot wants to merge 9 commits intodev_mainfrom
copilot/feature-simulate-multiple-families

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 13, 2026 •
edited
Loading

  • Understand current simulatePedigrees ID scheme (fam_shift * pow_gen offset)
  • Add sequential ID remapping after rbindlist in simulatePedigrees(): personID becomes 1:nrow, momID/dadID/spouseID remapped accordingly
  • Update tests: removed raw ID match assertion for n_fam=1; added test verifying IDs are exactly 1:nrow and all parent/spouse refs are in range
  • Updated roxygen @return to document sequential IDs

Copilot AI linked an issue Apr 13, 2026 that may be closed by this pull request
[Feature] make it easier to simulate multiple famlies at once #149
Open
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 13, 2026 •
edited
Loading

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copilot AI and others added 3 commits April 13, 2026 20:39
@smasongarrison
Add simulatePedigrees() function to simulate multiple families at once
b6de8f3 
Agent-Logs-Url: https://github.com/R-Computing-Lab/BGmisc/sessions/9367c84a-deb8-4f13-a855-367a204cc843

Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
@smasongarrison
Address code review: input validation, use rbindlist, fix test assert…
34f818b 
…ions

Agent-Logs-Url: https://github.com/R-Computing-Lab/BGmisc/sessions/9367c84a-deb8-4f13-a855-367a204cc843

Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
@smasongarrison
Fix minor punctuation in man/simulatePedigrees.Rd documentation
f3910a3 
Agent-Logs-Url: https://github.com/R-Computing-Lab/BGmisc/sessions/9367c84a-deb8-4f13-a855-367a204cc843

Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
Copilot AI changed the title [WIP] Add feature to simulate multiple families at once Add simulatePedigrees() for simulating multiple families in one call Apr 13, 2026
Copilot AI requested a review from smasongarrison April 13, 2026 20:42
@smasongarrison smasongarrison changed the base branch from main to dev_main April 13, 2026 21:00
@smasongarrison smasongarrison marked this pull request as ready for review April 13, 2026 21:01
@smasongarrison
Squashed commit of the following:
32684f6 
commit 42ae819
Author: Mason Garrison <garrissm@wfu.edu>
Date:   Mon Apr 13 16:08:31 2026 -0400

    Update test-makeLinks.R
@smasongarrison
smarter id handling
b33820a
@smasongarrison
pipes!
4455fc7
@smasongarrison
Update v2_pedigree.Rmd
c2fa605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smasongarrison smasongarrison Awaiting requested review from smasongarrison

Assignees

@smasongarrison smasongarrison

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] make it easier to simulate multiple famlies at once

2 participants

@smasongarrison