Skip to content

Hide sex legend by default and improve point scaling#102

Merged
smasongarrison merged 2 commits intodevfrom
scaling
Dec 20, 2025
Merged

Hide sex legend by default and improve point scaling#102
smasongarrison merged 2 commits intodevfrom
scaling

Conversation

@smasongarrison
Copy link
Copy Markdown
Member

This pull request introduces several improvements to the ggpedigree package, focusing on enhancing plot configuration flexibility, improving default visualization options, and refining the demonstration and testing of these features. The main changes include making the sex legend hidden by default, implementing dynamic scaling of point sizes based on pedigree size, and updating documentation and tests accordingly.

Plot configuration and visualization improvements:

  • The sex legend (Sex key) is now hidden by default in ggpedigree, making plots less cluttered unless explicitly requested. Associated logic in plot construction ensures the legend and label are only shown when desired. [1] [2] [3] [4] [5]
  • Point size in plots now automatically scales as a function of pedigree size, with different scaling factors for small, medium, and large pedigrees, improving readability across datasets of varying sizes. [1] [2] [3]

Documentation and demonstration updates:

  • The Game of Thrones dataset vignette was updated with tweaks to improve visualization, including changes to point_size, label inclusion, and example configurations for better clarity in demonstrations. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Testing and code maintenance:

  • Expanded and refactored tests for plot configuration, especially around point scaling by pedigree size, ensuring correct behavior for various input scenarios. [1] [2]
  • Minor code maintenance in data preparation scripts, such as commenting out unnecessary CSV writes. [1] [2] [3]

These changes collectively improve the usability and visual quality of pedigree plots, while ensuring robust configuration and clear documentation for users.

smasongarrison and others added 2 commits December 20, 2025 14:41
Set the sex legend to be hidden by default in ggpedigree plots and update the point size scaling logic to better handle different pedigree sizes. Adjusted tests to cover new scaling behavior and made minor improvements to the Game of Thrones dataset demonstration for clearer visualization.
@smasongarrison smasongarrison merged commit 41a0eca into dev Dec 20, 2025
5 checks passed
@smasongarrison
Copy link
Copy Markdown
Member Author

#94

@smasongarrison smasongarrison deleted the scaling branch December 30, 2025 21:55
@smasongarrison smasongarrison linked an issue Dec 31, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default plot appearance

1 participant