Hide sex legend by default and improve point scaling#102
Merged
smasongarrison merged 2 commits intodevfrom Dec 20, 2025
Merged
Conversation
Set the sex legend to be hidden by default in ggpedigree plots and update the point size scaling logic to better handle different pedigree sizes. Adjusted tests to cover new scaling behavior and made minor improvements to the Game of Thrones dataset demonstration for clearer visualization.
Member
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the
ggpedigreepackage, focusing on enhancing plot configuration flexibility, improving default visualization options, and refining the demonstration and testing of these features. The main changes include making the sex legend hidden by default, implementing dynamic scaling of point sizes based on pedigree size, and updating documentation and tests accordingly.Plot configuration and visualization improvements:
Sexkey) is now hidden by default inggpedigree, making plots less cluttered unless explicitly requested. Associated logic in plot construction ensures the legend and label are only shown when desired. [1] [2] [3] [4] [5]Documentation and demonstration updates:
point_size, label inclusion, and example configurations for better clarity in demonstrations. [1] [2] [3] [4] [5] [6] [7] [8] [9]Testing and code maintenance:
These changes collectively improve the usability and visual quality of pedigree plots, while ensuring robust configuration and clear documentation for users.