Refactor duplicated location-based LSP response handlers #493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses code duplication feedback:
send_definition_result(),send_references_result(), andsend_implementation_result()shared ~300 identical lines differing only in debug logging.Changes
send_location_result(params, debug_name)that handles all location-based LSP responsesdebug_nameparameter enables debug output for implementation handler while keeping definition/references handlers silentImplementation
This eliminates the risk of inconsistent bug fixes and simplifies maintenance of LSP location handling.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.