Skip to content

Conversation

@RAprogramm
Copy link
Owner

Summary

  • remove the unused String import in the response details module to satisfy -D warnings
  • bump the crate version to 0.23.2 and record the change in the changelog

Testing

  • cargo +nightly fmt --
  • cargo +1.90.0 clippy -- -D warnings
  • cargo +1.90.0 build --all-targets
  • cargo +1.90.0 test --all
  • cargo +1.90.0 doc --no-deps
  • cargo +1.90.0 audit
  • cargo +1.90.0 deny check

https://chatgpt.com/codex/tasks/task_e_68d6534965a8832b81250b9b3b903b82

@RAprogramm RAprogramm merged commit ed5383d into new_verison Sep 26, 2025
2 checks passed
@RAprogramm RAprogramm deleted the eye-of-ra/fix-unused-import-error branch September 26, 2025 09:12
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

#[cfg(not(feature = "serde_json"))]
impl ErrorResponse {
/// Attach plain-text details (available when `serde_json` is disabled).
#[must_use]
pub fn with_details_text(mut self, details: impl Into<String>) -> Self {
self.details = Some(details.into());
self

[P1] Restore alloc::String import for no_std builds

Removing the use alloc::string::String declaration leaves with_details_text referring to String without bringing it into scope when std is disabled. In default-features = false builds, String is not part of the prelude, so this method now fails to compile even though the crate is advertised as no_std compatible. Consider re‑adding the import (gated behind #[cfg(not(feature = "std"))]) or qualifying the type as alloc::string::String to keep no_std builds working while still avoiding the unused‑import warning.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants