Allow backtrace delegation through sources #78
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| fn struct_provide_method(fields: &Fields) -> Option<TokenStream> { | ||
| let backtrace = fields.backtrace_field()?; | ||
| let field = backtrace.field(); | ||
| let request = quote!(request); | ||
| let delegates_to_source = | ||
| matches!(backtrace.kind(), BacktraceFieldKind::Explicit) && !backtrace.stores_backtrace(); | ||
| let mut statements = Vec::new(); | ||
| let mut needs_trait_import = false; | ||
|
|
||
| if let Some(source_field) = fields.iter().find(|candidate| candidate.attrs.has_source()) { | ||
| needs_trait_import = true; | ||
| let member = &source_field.member; | ||
| statements.push(provide_source_tokens( | ||
| quote!(self.#member), | ||
| source_field, | ||
| &request | ||
| )); |
There was a problem hiding this comment.
[P1] Delegate backtrace to the correct source field
The generated provide implementation always forwards the request to the first #[source] field, even when a different field is the one annotated with #[backtrace]. For a struct with multiple sources where only the second source carries the backtrace (e.g. an optional secondary source annotated with #[source] and #[backtrace]), std::error::request_ref::<std::backtrace::Backtrace> will never reach that secondary source because only the first source is delegated. Before this change the derive called Error::backtrace(self) and the backtrace from the annotated source was still provided, so this is a regression for multi-source errors.
Useful? React with 👍 / 👎.
Summary
#[backtrace]on#[source]/#[from]fields when the type is an error and record whether the metadata was inferred or explicit to avoid duplicate provisioningError::providebodies to delegate requests to sources via a new internalThiserrorProvideshim before exposing stored backtracesprovidemodule for derived code, extend regression tests, and bump the crate versions/documentationTesting
https://chatgpt.com/codex/tasks/task_e_68cdfdc130f0832b888edbc0016e0f6d