Skip to content

Conversation

@RAprogramm
Copy link
Owner

Summary

  • stop using path dependencies for masterror-derive/masterror-template, rely on their declared versions and override them locally via .cargo/config
  • whitelist the workspace sources in include, add the config to the package payload, and bump the crate version to 0.10.4
  • refresh README badges/snippets and CHANGELOG for the new release

Testing

  • cargo +nightly fmt --
  • cargo +1.90.0 clippy --workspace --all-targets --all-features -- -D warnings
  • cargo +1.90.0 test --workspace --all-features --no-fail-fast
  • cargo +1.90.0 doc --no-deps
  • cargo deny check
  • cargo audit --deny warnings

https://chatgpt.com/codex/tasks/task_e_68ce8478e99c832bbb42404d39139d0c

@RAprogramm RAprogramm merged commit 3af9f57 into new_version Sep 20, 2025
2 checks passed
@RAprogramm RAprogramm deleted the codex/fix-ci-dry-run-implementation branch September 20, 2025 11:17
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

masterror/Cargo.toml

Lines 49 to 52 in 7297536

[features]
default = []

[P0] Switching to registry deps makes crate unparsable

The manifest now depends on masterror-derive and masterror-template solely by version, but both of those crates are still marked publish = false in their own manifests. Because .cargo/config.toml is not consulted when this package is consumed from crates.io, downstream builds will attempt to download masterror-derive 0.6.0/masterror-template 0.3.1 from the registry and fail with “no matching package found”. Unless these helper crates are actually published, this change makes masterror impossible to build for every external user.


Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants