5#6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
What
Reworks
.github/workflows/release-plz.ymlfor a production-grade release pipeline:rust-lang/crates-io-auth-actionmints a short-lived registry token; thereleasejob getsid-token: write. No more staticCRATES_IO_TOKENsecret.actions/create-github-app-tokengenerates a token for therelease-prcommand, soci.ymlactually runs on the release PR (the defaultGITHUB_TOKENcannot trigger workflows).releaseEnvironment. The publish job runs under areleaseenvironment for a required-reviewer protection gate.contents: readdefault; per-job permissions tightened (release-plz-prno longer needs write — the App token carries those scopes).Required before merge (repo owner)
Merging this without the setup below will break the release workflow.
timeweb-rs— repoRAprogramm/timeweb-rs, workflowrelease-plz.yml, environmentrelease.Contents: write,Pull requests: write), install it on this repo, add secretsRELEASE_PLZ_APP_IDandRELEASE_PLZ_APP_PRIVATE_KEY.releaseEnvironment with a required-reviewer rule.After merge
CRATES_IO_TOKENsecret once a release is verified.Out of scope
Repo-wide SHA-pinning of third-party actions — tracked separately.