fix: make container scan blocking on main to gate tag pushes#187
Merged
Conversation
Scan now runs on all pushes (main + tags). fail-build is true only on tag pushes so CVEs block the release but not the edge image. Gives visibility into the image state before pushing an immutable release tag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fail-build is now always true. The tag ruleset requires Container Scan to pass on the commit being tagged — if a CVE is found after a main push, the commit status goes red and the tag ruleset blocks any v* tag on that commit. PRs are unaffected since the scan only runs on push events, not PRs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fail-build: trueContainer Scanto pass on the commit being tagged — if CVEs are found after a main push, the commit status goes red and the ruleset blocks anyv*tag on that commitpushevents, not PRs, so merges are never blocked-pendingimage withfail-build: truebefore promoting to final release tagsThis closes the gap where an immutable release tag could be pushed to a commit with known CVEs, leaving a
-pendingimage stranded with no way to recover without burning a new tag.Test plan
Container Scangoes red and av*tag push is rejected by the rulesetContainer Scangoes green and a tag push is allowed through topublish-release🤖 Generated with Claude Code