refactor: provider registry name cleanup + Optional return types#191
Merged
Conversation
Replace nullable returns on getProvider() and resolveProvider() with Optional<GitProxyProvider>. InMemoryProviderRegistry wraps the map lookup in Optional.ofNullable(); JettyConfigurationBuilder.resolveProviderName uses orElseThrow() to fail fast on misconfiguration. All callers and tests updated accordingly.
This was referenced May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProviderRegistry.getProvider()andresolveProvider()now returnOptional<GitProxyProvider>instead of nullableGitProxyProviderInMemoryProviderRegistrywraps map lookup inOptional.ofNullable()JettyConfigurationBuilder.resolveProviderName()uses.orElseThrow()— misconfigured provider names still fail fast at startupAlso included (from earlier commits on this branch)
ProviderRegistry.resolveProvider()Javadoc corrected — null/blank "applies to all" semantic belongs inresolveProviderName(the caller), not the registry interfaceresolveToProviderIdrenamed toresolveProviderName;nameOrIdparameter renamed tonamethroughoutJettyConfigurationBuilderInMemoryProviderRegistryclass comment updatedJettyProxyFixturecomment fix (was "(type/host)")scripts/migrate-provider-ids.sql— one-off data fixup for renaming storedtype/hostFK values to providernamein all 6 tablestwoProvidersOfSameType_differentNames_haveDistinctProviderIdsandtwoProvidersOfSameType_permissionsAreKeptSeparatetestsTest plan
./gradlew :git-proxy-java-core:test :git-proxy-java-server:test— all pass