fix: resolve react-hooks/set-state-in-effect lint errors from v7 upgrade#213
Merged
Conversation
- Defer setState calls in useEffect bodies via Promise.resolve().then() so they run as microtasks rather than synchronously (satisfies the react-hooks/set-state-in-effect rule added in eslint-plugin-react-hooks@7) - Wire npmLint into the Gradle check task so frontend lint runs in CI and blocks merges going forward - Add concurrency groups to CI and Docker publish workflows; stale main branch runs are cancelled when superseded; tag runs always complete Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
coopernetes
force-pushed
the
fix/frontend-lint
branch
from
0727651 to
35facec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setStatecalls inuseEffectbodies viaPromise.resolve().then()so they run as microtasks rather than synchronously — satisfies thereact-hooks/set-state-in-effectrule added ineslint-plugin-react-hooks@7npmLintinto the Gradlechecktask so frontend lint runs as part of./gradlew buildin CI and blocks future mergesconcurrencygroups to CI and Docker publish workflows so stale main-branch runs are cancelled when superseded; tag runs always completeTest plan