fix: promote lettuce-core from compileOnly to implementation#223
Merged
Conversation
compileOnly fixes the Java 25 javac type-annotation error but leaves lettuce-core off the runtime classpath. Since spring-data-redis declares it optional, Gradle omits it entirely without an explicit dep; Spring Session Redis would throw NoClassDefFoundError at runtime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…is session test compileOnly fixed the Java 25 javac type-annotation error but left lettuce-core off the runtime classpath — spring-data-redis declares it optional in its Maven POM so Gradle omits it entirely. Spring Session Redis would throw NoClassDefFoundError at runtime with a Redis session store configured. Promoting to implementation ensures lettuce-core is on both the compile and runtime classpath. Adds RedisSessionRepositoryIntegrationTest: spins up a Valkey 8 container and exercises the same save/find/delete flow as MongoSessionRepositoryIntegrationTest, confirming lettuce connects and sessions round-trip correctly on Java 25. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #222.
compileOnlyfixed the Java 25 javac type-annotation error but leftlettuce-coreoff the runtime classpath —spring-data-redisdeclares itoptionalin its Maven POM, so Gradle omits it entirely without an explicit dep. Spring Session Redis would throwNoClassDefFoundErrorat runtime when a Redis session store is configured.Changing to
implementationputs it on both the compile and runtime classpath.