fix: skip diff generation for tag pushes#255
Merged
Merged
Conversation
Tag pushes send a null old SHA (all zeros), which caused the proxy to diff the entire repository history — producing 67K+ line diffs for a simple release tag push. Skip diff generation in both paths when the pushed ref is under refs/tags/: a tag is just a pointer to a commit already reviewed when it landed on the branch. closes #240 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffGenerationHook(store-and-forward) when the pushed ref is underrefs/tags/ScanDiffFilter(transparent proxy) via the existingisTagPush()check onGitRequestDetailsDiffGenerationHookTestcovering branch push, tag push skip, and delete skiptagPush_skipsDiffGenerationtest toScanDiffFilterTestCloses #240
Test plan
./gradlew :git-proxy-java-core:testpasses