perf: return summary projection from GET /api/push list endpoint#257
Merged
Conversation
Adds PushSummary — a lightweight DTO with only the 12 fields the list view needs — and wires it into the GET /api/push endpoint. JdbcPushStore overrides findSummaries() with a lean SELECT (no hydrate, no child-table queries), dropping the response from ~3 MB to a few KB per page load. closes #256 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
a54113c to
5dd8f75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PushSummary— a lightweight DTO with only the 12 fields the push list view needs (nosteps,commits, orattestation)PushStore.findSummaries()default implementation maps fromfind()in-memory (covers InMemory/Mongo stores);JdbcPushStoreoverrides with a leanSELECTof 12 columns and nohydrate()call, eliminating N×3 child-table queries per rowGET /api/pushnow returnsList<PushSummary>— no frontend changes needed since field names are a subset of the existingPushRecordtypeVerification
JdbcPushStoreIntegrationTest— two new tests: projection fields mapped correctly, filters pass throughPushControllerTest— existing list tests updated to verifyfindSummaries()is called with the correct query paramsjacocoTestCoverageVerificationpasses)Closes #256
🤖 Generated with Claude Code