massively overhaul rb3e_index.html #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the styling of the page to be a bit more modern. The page also has a theme per the running device state of light mode vs dark mode. Add's the ability to use (or hide) a lastfm api key for album art fetching. This isnt a perfect mechanism so you are also able to hide the api key field to not attempt getting album images. The album images are tagged and cached based on the corresponding song tag, so any arbitrary filtering of the song list will continue to match the cached image. filtered searches trigger faster api calls so the user isnt sat looking at a blank image. once search is unfiltered, the task for populating art for the entire library continues running. No longer need to click a search button to trigger a search, can live type and live filter.
Contributor
Author
2024-08-11.12-26-54_1_3.mp4 |
Collaborator
|
This one got overlooked, merged, thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the styling of the page to be a bit more modern. The page also has a theme per the running device state of light mode vs dark mode. Add's the ability to use (or hide) a lastfm api key for album art fetching. This isnt a perfect mechanism so you are also able to hide the api key field to not attempt getting album images. The album images are tagged and cached based on the corresponding song tag, so any arbitrary filtering of the song list will continue to match the cached image. filtered searches trigger faster api calls so the user isnt sat looking at a blank image. once search is unfiltered, the task for populating art for the entire library continues running. No longer need to click a search button to trigger a search, can live type and live filter.