feat(cq): add support for cq and comp_channel #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. implement generic builder for both cq and cq_ex 2. implement comp_channel and associate its lifetime with cq
Contributor
Author
|
Maybe we can put |
Contributor
I agree, as |
examples/test_cq.rs
Outdated
| let ctx = device.open().unwrap(); | ||
|
|
||
| let comp_channel = comp_channel::CompletionChannel::new(&ctx).unwrap(); | ||
| let mut builder = completion_queue::CompletionQueueBuilder::new(&ctx); |
Contributor
There was a problem hiding this comment.
What about using ctx.create_comp_channel and ctx.create_cq_builder? So that we don't need to pass the argument explicitly.
Contributor
Author
There was a problem hiding this comment.
Yeah we can add some methods at context level to invoke these implementations.
dragonJACson
approved these changes
Aug 18, 2024
Contributor
Author
|
Ref #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.