feat(qp): implement PostRecvGuard & SetScatterGatherEntry #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FujiZ
commented
Oct 1, 2024
FujiZ
commented
- Implement SetScatterGatherEntry for post_send & post_recv
- Implement PostRecvGuard for post_recv
Codecov ReportAttention: Patch coverage is
|
FujiZ
force-pushed
the
dev/post-recv
branch
2 times, most recently
from
9d3723d to
508927b
Compare
dragonJACson
reviewed
Oct 1, 2024
dragonJACson
reviewed
Oct 1, 2024
| fn start_post_recv(&mut self) -> PostRecvGuard<'_> { | ||
| PostRecvGuard { | ||
| qp: unsafe { self.qp() }, | ||
| wrs: Vec::new(), |
Contributor
There was a problem hiding this comment.
We should align the logic in BasicPostSendGuard using Vec::new() as well? Maybe in a separate commit.
Contributor
Author
There was a problem hiding this comment.
Yeah, I think Vec::new() is better when we want to create an empty vector.
dragonJACson
reviewed
Oct 1, 2024
1. Implement SetScatterGatherEntry for post_send & post_recv 2. Implement PostRecvGuard for post_recv
dragonJACson
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.