refactor: define more error types for DeviceContext #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (55.35%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.
|
Contributor
Author
|
Change the definition according to https://gist.github.com/quad/a8a7cc87d1401004c6a8973947f20365. Now it looks more consistent to me. |
Define error types in the way that conform to the practice mentioned in https://gist.github.com/quad/a8a7cc87d1401004c6a8973947f20365 - AllocateProtectionDomainError - QueryDeviceError - QueryPortError - QueryGidTableError - QueryGidError Signed-off-by: FujiZ <i@fujiz.me>
dragonJACson
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try different ways of defining error types in order to get some insights. However, I haven't found a consistent methodology yet. Some of these definitions seem verbose and weird.