feat(ibverbs): only provide unsafe interface for registering MR #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonJACson
force-pushed
the
dev/stride-support
branch
from
26243ba to
34eb46e
Compare
Codecov ReportAttention: Patch coverage is
|
dragonJACson
force-pushed
the
dev/stride-support
branch
4 times, most recently
from
bdea8bd to
c90fb93
Compare
dragonJACson
changed the title
dragonJACson
commented
Feb 22, 2025
| /// and that the memory remains accessible and unmodified as needed. | ||
| pub(crate) unsafe fn reg_mr( | ||
| pd: &'pd ProtectionDomain, ptr: usize, len: usize, access: AccessFlags, | ||
| ) -> Result<Self, RegisterMemoryRegionError> { |
Contributor
Author
There was a problem hiding this comment.
Types like Vec<T> would reallocate and move memory around, which would break the rule of MR (need Pinned memory), but use something like Pin<T> as parameter is also not pretty feasible for CUDA memory etc.. Do you think provide an interface for primitive types with Pin<T> and lifetime bound, another interface with bare usize as pointer a good idea? @FujiZ
Contributor
There was a problem hiding this comment.
I am not familiar with the Pin<T> API, could you demostrate the usage of Pin<T> with reg_mr in another MR once this one is merged?
dragonJACson
force-pushed
the
dev/stride-support
branch
from
c90fb93 to
e926747
Compare
Signed-off-by: Luke Yue <lukedyue@gmail.com>
dragonJACson
force-pushed
the
dev/stride-support
branch
from
e926747 to
1615500
Compare
FujiZ
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.