feat(ibverbs): improve Device and DeviceList implementation
#50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dragonJACson
commented
Feb 21, 2025
dragonJACson
commented
- Define custom Error type for getting device list and open device.
- Provide the ability to access Device from DeviceList using index.
- Define a trait for accessing DeviceInfo, implement it for both Device and DeviceContext.
- More unit-tests.
dragonJACson
force-pushed
the
dev/refine-device
branch
from
72e5510 to
49065c6
Compare
dragonJACson
commented
Feb 21, 2025
|
|
||
| /// Trait for common device information access | ||
| pub trait DeviceInfo { | ||
| /// Returns the name of the device, for example, `mlx5_0` |
Contributor
Author
There was a problem hiding this comment.
@FujiZ Do you think return an empty String when device name is NULL would be a better solution? I think it would make life easier.
Contributor
There was a problem hiding this comment.
I'm not sure. Theoretically NULL is different from a NULL-ternimated empty string, but the users usually do not care about the difference.
dragonJACson
force-pushed
the
dev/refine-device
branch
4 times, most recently
from
aff5c05 to
74ba624
Compare
Codecov ReportAttention: Patch coverage is
|
1. Define custom Error type for getting device list and open device. 2. Provide the ability to access Device from DeviceList using index. 3. Define a trait for accessing DeviceInfo, implement it for both Device and DeviceContext. 4. More unit-tests. Signed-off-by: Luke Yue <lukedyue@gmail.com>
Signed-off-by: Luke Yue <lukedyue@gmail.com>
dragonJACson
force-pushed
the
dev/refine-device
branch
from
74ba624 to
118ba81
Compare
dragonJACson
commented
Feb 22, 2025
dragonJACson
changed the title
Device and DeviceList implementation
FujiZ
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.