Skip to content

refactor: align Infiniband to InfiniBand and return empty String when device name is NULL #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dragonJACson merged 2 commits into from
Feb 25, 2025
Merged

refactor: align Infiniband to InfiniBand and return empty String when device name is NULL #53

dragonJACson merged 2 commits into from
Feb 25, 2025

Conversation

@dragonJACson
Copy link
Contributor

@dragonJACson dragonJACson commented Feb 24, 2025

No description provided.

@dragonJACson
refactor: rename Infiniband to InfiniBand which is more formal
b658c9a 
Signed-off-by: Luke Yue <lukedyue@gmail.com>
@dragonJACson
refactor(ibverbs): return String instead of Option<String> for device…
3d3c45b 
… name

RDMA device would have a device name 99% of time, when it really doesn't
have one because of buggy configuration, we could still use an empty
string for it.

Signed-off-by: Luke Yue <lukedyue@gmail.com>
@codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ibverbs/device_context.rs 77.77% 2 Missing ⚠️
src/ibverbs/device.rs 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/rdmacm/communication_manager.rs 89.40% <ø> (ø)
src/ibverbs/device.rs 87.50% <66.66%> (ø)
src/ibverbs/device_context.rs 87.14% <77.77%> (+0.09%) ⬆️

@dragonJACson dragonJACson merged commit 40fb9e1 into main Feb 25, 2025
5 checks passed
@dragonJACson dragonJACson deleted the dev/align-ib branch February 26, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FujiZ FujiZ FujiZ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dragonJACson @FujiZ