Skip to content

Conversation

@shadychan
Copy link
Contributor

No description provided.

@shadychan shadychan force-pushed the shady/device-test branch 2 times, most recently from afda48c to c163460 Compare September 8, 2025 00:02
@dragonJACson
Copy link
Contributor

dragonJACson commented Sep 13, 2025

@shadychan Please try to cherry-pick #73 to see if it fixes the CI

dev_path: [0; 256usize],
ibdev_path: [0; 256usize],
});
for (j, &b) in CString::new(format!("mock{}", i))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be format!("mock{i}"); but this is fine, try to use

ibv_dev.dev_name.copy_from_slice(CString::new(format!("mock{i}")).unwrap().as_bytes_with_nul());

It seems dev_name are [i8; 64], while CString::as_bytes_with_nul returns &[u8]. Guess we need to change rdma-mummy-sys cc @FujiZ

@dragonJACson
Copy link
Contributor

@shadychan Please try to cherry-pick #73 to see if it fixes the CI

It seems that the PRs not from this repo wouldn't have access to the repository secrets, so codecov failed to upload the coverage info, I've remove the need of token on codecov's website.

@shadychan
Copy link
Contributor Author

@shadychan Please try to cherry-pick #73 to see if it fixes the CI

@dragonJACson Still got Error: Got unexpected extra argument (github) on CI command ./codecov --verbose upload-process --disable-search --fail-on-error -t $CODECOV_TOKEN --git-service github -f ./lcov.info

@dragonJACson
Copy link
Contributor

@shadychan Please try to cherry-pick #73 to see if it fixes the CI

@dragonJACson Still got Error: Got unexpected extra argument (github) on CI command ./codecov --verbose upload-process --disable-search --fail-on-error -t $CODECOV_TOKEN --git-service github -f ./lcov.info

Yes, I guess that's because $CODECOV_TOKEN couldn't be read, could you please cherry-pick the newest commit in #73 and try again?

@codecov
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

❌ Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ibverbs/device.rs 98.41% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/ibverbs/device.rs 94.35% <98.41%> (+7.50%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shadychan and others added 2 commits September 13, 2025 20:55
Signed-off-by: Shady Chan <chanyulin@foxmail.com>
Signed-off-by: Luke Yue <lukedyue@gmail.com>
@dragonJACson dragonJACson merged commit f4c1dd4 into RDMA-Rust:main Sep 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants