-
Notifications
You must be signed in to change notification settings - Fork 5
test(ibverbs): add more tests for Device and DeviceList #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
afda48c to
c163460
Compare
c163460 to
b3c9969
Compare
|
@shadychan Please try to cherry-pick #73 to see if it fixes the CI |
src/ibverbs/device.rs
Outdated
| dev_path: [0; 256usize], | ||
| ibdev_path: [0; 256usize], | ||
| }); | ||
| for (j, &b) in CString::new(format!("mock{}", i)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be format!("mock{i}"); but this is fine, try to use
ibv_dev.dev_name.copy_from_slice(CString::new(format!("mock{i}")).unwrap().as_bytes_with_nul());
It seems dev_name are [i8; 64], while CString::as_bytes_with_nul returns &[u8]. Guess we need to change rdma-mummy-sys cc @FujiZ
b3c9969 to
8666fad
Compare
It seems that the PRs not from this repo wouldn't have access to the repository secrets, so codecov failed to upload the coverage info, I've remove the need of token on codecov's website. |
8666fad to
468d6e3
Compare
@dragonJACson Still got |
Yes, I guess that's because |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
468d6e3 to
65a831c
Compare
Signed-off-by: Shady Chan <chanyulin@foxmail.com>
Signed-off-by: Luke Yue <lukedyue@gmail.com>
65a831c to
bfac42f
Compare
No description provided.