refactor(ibverbs): wrap DeviceContext, ProtectionDomain, MemoryRegion in Arc #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonJACson
force-pushed
the
dev/no-lifetime-mark
branch
from
19237fc to
0537590
Compare
… in Arc Currently we are using lifetime mark for them, but this would introduce difficulty for user to encap them in a single struct (which would be a self-referential struct). Both of them would only be used in control path, so change to wrap them in Arc wouldn't be a big performance issue, but could benefit users a lot. Signed-off-by: Luke Yue <lukedyue@gmail.com>
dragonJACson
force-pushed
the
dev/no-lifetime-mark
branch
from
0537590 to
ada2026
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
FujiZ
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are using lifetime mark for them, but this would introduce difficulty for user to encap them in a single struct (which would be a self-referential struct). Both of them would only be used in control path, so change to wrap them in Arc wouldn't be a big performance issue, but could benefit users a lot.