Skip to content

Conversation

@dragonJACson
Copy link
Contributor

Expose DeviceContext::context, ProtectionDomain::pd, MemoryRegion::mr, and CompletionChannel::comp_channel so callers can retrieve the underlying ibv_* handles when interoperating with accelerators such as NVIDIA DPA or with direct verbs.

Keep the methods unsafe because the returned pointers are not lifetime-bound to the wrapper types.

@dragonJACson dragonJACson self-assigned this Nov 22, 2025
@dragonJACson dragonJACson requested a review from FujiZ November 22, 2025 04:41
@dragonJACson dragonJACson force-pushed the dev/raw-ptr branch 2 times, most recently from b741ac3 to 4c8f666 Compare November 22, 2025 07:00
Expose `DeviceContext::context`, `ProtectionDomain::pd`,
`MemoryRegion::mr`, and `CompletionChannel::comp_channel` so callers can
retrieve the underlying `ibv_*` handles when interoperating with
accelerators such as NVIDIA DPA or with direct verbs.

Keep the methods unsafe because the returned pointers are not
lifetime-bound to the wrapper types.

Signed-off-by: Luke Yue <lukedyue@gmail.com>
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ibverbs/device_context.rs 76.47% 4 Missing ⚠️
src/ibverbs/completion.rs 50.00% 3 Missing ⚠️
src/ibverbs/memory_region.rs 0.00% 3 Missing ⚠️
src/ibverbs/protection_domain.rs 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/ibverbs/device.rs 94.88% <100.00%> (+0.53%) ⬆️
src/rdmacm/communication_manager.rs 87.05% <100.00%> (+0.03%) ⬆️
src/ibverbs/completion.rs 81.95% <50.00%> (-0.61%) ⬇️
src/ibverbs/memory_region.rs 87.50% <0.00%> (-9.06%) ⬇️
src/ibverbs/protection_domain.rs 86.95% <0.00%> (-13.05%) ⬇️
src/ibverbs/device_context.rs 86.16% <76.47%> (-0.54%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dragonJACson dragonJACson requested a review from FujiZ November 22, 2025 08:44
@dragonJACson dragonJACson merged commit e7c5357 into main Nov 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants