Improvements to LightVolumeAudiolink#61
Merged
Merged
Conversation
* Add options to control how much boost is provided from audiolink similar to how Poiyomi's shader uses these factors * Switch to using the light volume Intensity value rather than multiplying the color itself * Also switch to using the material emission intensity value * Allow setting the base color of mesh renderers as well as emission color * Improve efficiency in for loops, decreasing the number of extern calls per iteration * Add a "no change" option for the color, so we can boost intensity without affecting color. Good for a case where your colors are set elsewhere
Owner
|
Thanks for the improvements! The reason why I didn't use the intensity is to be able to set a unique intensity per Light Volume: some of the volumes might need to be dim, some - bright, and I thought it would be nice to have a control on it. |
Contributor
Author
|
Oh that makes sense then! I had exactly the same thought, but in my case I just made sure to store the initial values of the light volumes intensity and then use that as the basis for audiolink to react - thus you can have different values for all of the ones attached to this one object. Good too see I wasn't too far off base here! |
* Fixed a typo where I had 'Automatic' instead of 'Auto' * Added support for using the AL volume as a band
|
I'm using this code in one of my worlds (Chromium) and it works perfectly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added options to control how much boost is provided from audiolink similar to how Poiyomi's shader uses these factors - namely separate values to add and multiply the base intensity by at minimum and maximum audio levels. This gets us much more control over the effects, including decreasing when audio increases.
Switched to using the light volume Intensity value and material emission value rather than multiplying the color itself - I'm not sure if there was a specific reason it was done the other way, so I can rework this if I've gone the wrong direction here.
Added a checkbox to allow setting the base color of the associated mesh renderers as well as the emission color.
Added a "no change" option for the color, so we can boost intensity without affecting color. Good for a case where your colors are set in the light volume or material programmatically.
Improved efficiency for the for loops, this should remove one extern per iteration by caching the stop value up front.