Allow for custom request headers #18
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds support for custom request headers to
Request::request()via a new optional parameter $additional_headers = []. This is backwards compatible: existing behavior is unchanged unless a caller passes custom headers. Library-set headers (e.g.,Accept,Authorization) take precedence and will overwrite any values for the same keys provided in$additional_headers.Related Issues: Closes #4 / Closes #17
Related PRs: Supersedes #5 and #16
Benefits
Some integrations require sending extra headers such as:
Prefer: maxpagesize=...Content-Encoding: gzipAllowing callers to pass headers directly avoids expanding the method signature with new dedicated parameters.
Possible Drawbacks
None identified.
Verification Process
$additional_headers.Applicable Issues
#4 and #17