Skip to content

Conversation

@Cxxshyy
Copy link
Contributor

@Cxxshyy Cxxshyy commented Sep 27, 2022

Summary

fixed issue where options weren't seen by the user due to vs code theme.
...

@Cxxshyy Cxxshyy closed this Sep 27, 2022
@Cxxshyy Cxxshyy reopened this Sep 27, 2022
@Cxxshyy
Copy link
Contributor Author

Cxxshyy commented Sep 27, 2022

This is the new version of the css styling if you can test for yourself and let me know

opacity: 0.78;
}
`;

Copy link
Collaborator

@unwls unwls Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes on this PR look nice, but there still seems to be an issue with the white VSCode theme.
Although it's not as popular as darker themes you wanna try solving this problem(Could be annoying to fix this)?

Current Issue

VSCode white theme

If you are satisfied with the current change and don't wanna bother dealing with the white VSCode theme, it's totally fine!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes i never tested it out with white i will take a look later today.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi i never managed to find a way to fix it unfortunately so i say merge it and in the future if someone raises the issue we can take a better look

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@unwls unwls merged commit 2c233a2 into REST-API-Client:main Oct 11, 2022
@unwls unwls added New Feature New feature update Enhancement Refactoring existing code and removed New Feature New feature update labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Refactoring existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants