Fix several bugs #464
Merged
Fix several bugs #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Maybe adding a test for it? |
randy3k
reviewed
Aug 6, 2021
| if (is_rmarkdown(uri)) { | ||
| content <- purl(content) | ||
| } | ||
| # replace tab with a space since the width of a tab is 1 in LSP but 8 in getParseData(). |
Member
There was a problem hiding this comment.
cf: https://github.com/wch/r-source/blob/8a0aaaa4feac8a97c211771bda8fd1454144ee3c/src/main/gram.y#L597
the tab size is not configurable at all.
Member
Author
There was a problem hiding this comment.
Thanks for digging into the source!
Member
Author
|
Test cases are added. Any other suggestions? |
Member
|
Thanks for working on it. LGTM. |
randy3k
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #463
Hovering on the left part of a symbol might capture the symbol token with
document$detect_token()while the XPath captures the token on the left of the cursor, e.g. an operator, and thus shows the workspace definition of the captured token rather than the scope definition.This PR:
\twith a space inparse_document()to make the width of tab consistent between LSP andgetParseData().exprlistnodes appear in the XML syntax tree.