Enable default R location to be used on mac/linux if none is supplied#340
Merged
renkun-ken merged 3 commits intoREditorSupport:masterfrom May 25, 2020
gowerc:feature-default-mac-R
Merged
Enable default R location to be used on mac/linux if none is supplied#340renkun-ken merged 3 commits intoREditorSupport:masterfrom gowerc:feature-default-mac-R
renkun-ken merged 3 commits intoREditorSupport:masterfrom
gowerc:feature-default-mac-R
Conversation
Contributor
Author
|
Hey @andycraig & @renkun-ken, Updated the PR to look for the path variable across all 3 OS's. Works fine on my Mac but need someone to test it on windows as I don't have access to a windows machine sorry :( |
Member
|
I test this on both macOS and Ubuntu and it works well. Maybe @andycraig could take a look at Windows. |
Member
|
I test this on Windows 10 VM and it works as expected. |
Member
|
@gowerc Great works! These have a lot of great improvements. I will publish a new version this night. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
#339
(If you do not have screenshot) How can I check this pull request?
Please find a gif of the above below: