Skip to content

Enable default R location to be used on mac/linux if none is supplied#340

Merged
renkun-ken merged 3 commits intoREditorSupport:masterfrom
gowerc:feature-default-mac-R
May 25, 2020
Merged

Enable default R location to be used on mac/linux if none is supplied#340
renkun-ken merged 3 commits intoREditorSupport:masterfrom
gowerc:feature-default-mac-R

Conversation

@gowerc
Copy link
Copy Markdown
Contributor

@gowerc gowerc commented May 23, 2020

What problem did you solve?

#339

(If you do not have screenshot) How can I check this pull request?

  • Ensure R is on your search path
  • open vscode with default settings and run "create new R terminal"
  • a new R session should open
  • change vscode default settings for R location on mac/linux to a null/junk location
  • run "create new R terminal"
  • A error message should appear saying unable to open the terminal

Please find a gif of the above below:

2020-05-23 22 43 27

@gowerc gowerc changed the title added functionality to search PATH in mac/linux Enable default R location to be used on mac/linux if none is supplied May 23, 2020
@gowerc
Copy link
Copy Markdown
Contributor Author

gowerc commented May 24, 2020

Hey @andycraig & @renkun-ken, Updated the PR to look for the path variable across all 3 OS's. Works fine on my Mac but need someone to test it on windows as I don't have access to a windows machine sorry :(

@renkun-ken
Copy link
Copy Markdown
Member

I test this on both macOS and Ubuntu and it works well. Maybe @andycraig could take a look at Windows.

@renkun-ken
Copy link
Copy Markdown
Member

I test this on Windows 10 VM and it works as expected.

@renkun-ken renkun-ken merged commit 560101b into REditorSupport:master May 25, 2020
@Ikuyadeu
Copy link
Copy Markdown
Member

@gowerc Great works! These have a lot of great improvements. I will publish a new version this night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants