Refactor R code#602
Merged
ManuelHentschel merged 11 commits intoREditorSupport:masterfrom Apr 2, 2021
Merged
Conversation
renkun-ken
reviewed
Apr 1, 2021
renkun-ken
reviewed
Apr 1, 2021
renkun-ken
reviewed
Apr 1, 2021
Member
|
I checked rstudioapi and it works now. |
renkun-ken
reviewed
Apr 19, 2021
renkun-ken
reviewed
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains some restructuring of the R code used in the extension. Changes are:
init.Rto their own filevsc.R. This hopefully makes it easier to contribute new functions etc. (invsc.R) without having to worry about the technical issues solved ininit.R.tools:vscodeafter loading default packages. This makes it possible to mask e.g.Viewwithout having to mess with the environment of theutilspackage itself.Move temporary files (request.log,request.lock) to a temporary directory instead of the home directory.The last two points imply that the directory~/.vscode-Ris not needed anymore.Todo:Check Rstudio apiFind solution for self-managed sessions (Maybe we should leave an optional "link file" in~/.vscode-R? Or expose the path toinit.Rin the extension files somehow and let the user copy it to their.Rprofile?)