Skip to content

Fix replacing base::.External.graphics#625

Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken:fix-plot
Apr 19, 2021
Merged

Fix replacing base::.External.graphics#625
renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken:fix-plot

Conversation

@renkun-ken
Copy link
Copy Markdown
Member

What problem did you solve?

Closes #624

This PR fixes a regression introduced in #602 where base::.External.graphics is not successfully replaced to trigger graphics replay so that functions like abline(), points() could cause the plot to refresh.

(If you do not have screenshot) How can I check this pull request?

When each the following lines is run, the png plot file is refreshed in vscode.

plot(rnorm(100))
abline(h = 0, col = "red")
abline(v = 0, col = "blue")

@renkun-ken renkun-ken mentioned this pull request Apr 19, 2021
@renkun-ken renkun-ken merged commit 5925d08 into REditorSupport:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session watcher won't update plots.

2 participants