Fix send code for newlines and Radian #114 #117#119
Merged
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom Aug 18, 2019
Merged
Fix send code for newlines and Radian #114 #117#119Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
Conversation
Member
|
It looks perfect to me, except that I only have a little experience with VS Code extensions. |
Collaborator
Author
Member
|
@andycraig Thank you for your contribution! |
Collaborator
Author
|
@Ikuyadeu Thank you! |
Collaborator
Author
|
Hi @Ikuyadeu, when you have time would you be able to do a release with this change? |
Member
|
@andycraig Sorry, I'm late. I just released the new version now. |
Collaborator
Author
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114
Fixes #117
What problem did you solve?
When sending code to console (R or Radian), blank lines before the code chunk are also sent (Newlines when sending code to Radian #114).
When sending code to Radian console, identation is odd (Messy indentation in console when sending text to Radian #117).
This PR adds a new setting,
r.bracketedPaste, which enables bracketed paste mode to fix the indentation problems with Radian. This also works with the R console but not with readline 6 or before, so I have set it tofalseby default.(If you have)Screenshot
R with
bracketedPasteset tofalse, using the commandR: Run Selection/Linewith the cursor on line 3 - note that there is no blank prompt in the console BEFOREwhich shows that no blank lines have been sent:
Radian with
bracketedPasteset totrue, using the commandR: Run Selection/Line in Active Terminalwith the cursor on line 3 - note lack of blank prompt, and correct indentation:@randy3k Could you look at my bracketed paste mode code (lines 106-107 of
src/extension.ts)? I think it is fine but you have a lot more experience with bracketed paste mode than I do. Thank you!