RMarkdown knit support#122
Conversation
|
@dominicwhite @mattva01 Thank you very much for this! @Ikuyadeu I’m busy this weekend but I could review this PR next week if you’d like. |
|
@dominicwhite Thank you for your PR! This PR is WIP isn't is? I will check this after you remove the WIP. @andycraig Thank you for telling me. I will check this PR in this week end if @dominicwhite finished. |
|
@andycraig @Ikuyadeu Thanks for the suggestions. I just added two extra commands, to Knit to HTML and All formats. I will look into the icons you suggested later today, and try to get the pull request ready to by merged. |
|
@andycraig @Ikuyadeu I have removed the WIP tag, so please review and let me know if you would like any changes. Regarding icons: In the end I left a single Run Source icon in place, which reruns the basic Knit command (to the default output type). The other three Knit options are available as commands, but I could not find 4 appropriate icons in the Visual Studio collections. |
|
@dominicwhite Thank you for a good fix. |
|
@dominicwhite Sorry, my reply is late. I checked this now. |
What problem did you solve?
Fixes #121
I'd independently had a the same issue as @a-torgovitsky in Issue #121 - needing a shortcut to knit RMarkdown files.
@mattva01 and I added commands to knit based on @a-torgovitsky's code snippet in his issue. Specifically:
Screenshot
An open Rmd file now looks like:
However, we are currently reusing the "Run Source" icon for both Knit options (default and PDF):
I tried creating a custom icon, but the text was far to small to be functionally useful, so I'm not sure what the best solution to this is (perhaps just a single Run Source icon, which runs the default Knit command? Or is reusing the Run Source icon too confusing).
Additional commands (that I would like, at least)