Add alwaysUseActiveTerminal setting #123#133
Merged
Ikuyadeu merged 4 commits intoREditorSupport:masterfrom Oct 13, 2019
Merged
Conversation
Member
|
@andycraig Thank you for a lot of work! |
Collaborator
Author
|
@Ikuyadeu Happy to hear that :) Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #123
What problem did you solve?
Currently, only command
R: Run Selection/Line in Active Terminalworks for terminals other than the R Interactive terminal. This PR adds a settingr.alwaysUseActiveTerminal(falseby default). When this setting is enabled, all commands (R: Run Source,R: Preview Dataframe,R: Knit Rmdetc.) are sent to the active terminal. This allows SSH users etc. to access the full functionality of this extension.Screenshot
Before this PR, both
R: Run Selection/LineandR: Preview Dataframewould have opened a new R Interactive terminal.Notes
I needed to create the function
chooseTerminalAndSendTextoutsideactivateinextension.tsso that it could be exported for use inpreview.ts. I decided to put it inrTerminal.ts. I moved the associated terminal choosing/sending functions in there, because they couldn't be exported while insideactivateeither. I created a separate commit just for moving these functions, to make it easier to compare the changes.Command
R: Run Selection/Line in Active Terminalis probably redundant now, but I left it in there so that this PR doesn't remove any functionality.