WIP Migrate to vscode-test #315#316
Closed
andycraig wants to merge 10 commits intoREditorSupport:masterfrom
Closed
WIP Migrate to vscode-test #315#316andycraig wants to merge 10 commits intoREditorSupport:masterfrom
andycraig wants to merge 10 commits intoREditorSupport:masterfrom
Conversation
Member
|
I tried running the test but the following error occurs: |
Collaborator
Author
|
@renkun-ken Thanks for testing! That's similar to an error I was getting earlier but I thought I'd fixed. Can you check if the following files exist? (Note they are JavaScript
|
Collaborator
Author
|
Actually I'm getting the same error after removing my |
c3dd22b to
29691f2
Compare
Because it no longer works.
29691f2 to
b66cad8
Compare
Collaborator
Author
|
I'm making several changes so I'm going to close this PR and open a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #315
What problem did you solve?
Unit tests were not working. This PR migrates unit tests to
vscode-test. Now unit tests work again.How can I check this pull request?