Skip to content

WIP Migrate to vscode-test #315#316

Closed
andycraig wants to merge 10 commits intoREditorSupport:masterfrom
andycraig:migrate-vscode-test
Closed

WIP Migrate to vscode-test #315#316
andycraig wants to merge 10 commits intoREditorSupport:masterfrom
andycraig:migrate-vscode-test

Conversation

@andycraig
Copy link
Copy Markdown
Collaborator

Closes #315

What problem did you solve?

Unit tests were not working. This PR migrates unit tests to vscode-test. Now unit tests work again.

How can I check this pull request?

  1. Run -> Start Debugging...
  2. Select 'Launch Tests' from the dropdown
  3. Press F5
  4. Observe Debug Console shows output ending with
    ✓ Selecting multi-line bracket with pipe    spec.js:76
    ✓ Selecting shorter RStudio comparison      spec.js:76
  22 passing (164ms)

@andycraig andycraig changed the title Migrate to vscode-test Migrate to vscode-test #315 May 9, 2020
@renkun-ken
Copy link
Copy Markdown
Member

I tried running the test but the following error occurs:

Error: Error: Cannot find module '/Users/ken/Workspaces/github/vscode-R/out/test/suite/index'
Require stack:
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-fork.js
	at h._doHandleExtensionTests (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:827:661)
	at processTicksAndRejections (internal/process/task_queues.js:85:5)
HttpError: request to https://api.github.com/user failed, reason: connect ECONNREFUSED 13.250.168.23:443
	at /Users/ken/.vscode/extensions/shan.code-settings-sync-3.4.3/out/extension.js:761:1113
	at processTicksAndRejections (internal/process/task_queues.js:85:5)
HttpError: request to https://api.github.com/gists/8398cc2babf3042d1ede4cb33524d4f1 failed, reason: connect ECONNREFUSED 13.250.168.23:443
	at /Users/ken/.vscode/extensions/shan.code-settings-sync-3.4.3/out/extension.js:761:1113
	at processTicksAndRejections (internal/process/task_queues.js:85:5)

@andycraig
Copy link
Copy Markdown
Collaborator Author

@renkun-ken Thanks for testing! That's similar to an error I was getting earlier but I thought I'd fixed. Can you check if the following files exist? (Note they are JavaScript .js files.)

  • /Users/ken/Workspaces/github/vscode-R/out/test/suite/index.js
  • /Users/ken/Workspaces/github/vscode-R/out/test/runTest.js

@andycraig
Copy link
Copy Markdown
Collaborator Author

Actually I'm getting the same error after removing my out directory. I had evidently created that with some earlier operation.

@andycraig andycraig changed the title Migrate to vscode-test #315 WIP Migrate to vscode-test #315 May 9, 2020
@andycraig andycraig force-pushed the migrate-vscode-test branch from c3dd22b to 29691f2 Compare May 9, 2020 08:58
Because it no longer works.
@andycraig andycraig force-pushed the migrate-vscode-test branch from 29691f2 to b66cad8 Compare May 9, 2020 09:04
@andycraig
Copy link
Copy Markdown
Collaborator Author

I'm making several changes so I'm going to close this PR and open a new one.

@andycraig andycraig closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate tests to vscode-test

2 participants