Skip to content

(Maybe) Fix Aliases #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renkun-ken merged 1 commit into from
Jan 21, 2021
Merged

(Maybe) Fix Aliases #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/rHelpProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import * as cp from 'child_process';
import * as kill from 'tree-kill';

import * as rHelp from './rHelp';
import * as path from 'path';
import * as fs from 'fs';
import * as os from 'os';


export interface RHelpProviderOptions {
Expand Down Expand Up @@ -153,6 +156,8 @@ export class HelpProvider {
export interface AliasProviderArgs {
// R path, must be vanilla R
rPath: string;
// cwd
cwd?: string;
// getAliases.R
rScriptFile: string;

Expand All @@ -172,6 +177,7 @@ interface PackageAliases {
export class AliasProvider {

private readonly rPath: string;
private readonly cwd?: string;
private readonly rScriptFile: string;
private allPackageAliases?: null | {
[key: string]: PackageAliases;
Expand All @@ -181,6 +187,7 @@ export class AliasProvider {

constructor(args: AliasProviderArgs){
this.rPath = args.rPath;
this.cwd = args.cwd;
this.rScriptFile = args.rScriptFile;
this.persistentState = args.persistentState;
}
Expand Down Expand Up @@ -284,16 +291,26 @@ export class AliasProvider {
this.allPackageAliases = null;
const lim = '---vsc---'; // must match the lim used in R!
const re = new RegExp(`^.*?${lim}(.*)${lim}.*$`, 'ms');
const cmd = `${this.rPath} --silent --no-save --no-restore --slave -f "${this.rScriptFile}"`;
const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'vscode-R-aliases-'));
Comment thread
renkun-ken marked this conversation as resolved.
const tempFile = path.join(tempDir, 'aliases.json');
const cmd = `${this.rPath} --silent --no-save --no-restore --slave -f "${this.rScriptFile}" > "${tempFile}"`;
Comment thread
renkun-ken marked this conversation as resolved.

try{
const txt = cp.execSync(cmd, {encoding: 'utf-8'});
// execute R script 'getAliases.R'
// aliases will be written to tempDir
cp.execSync(cmd, {cwd: this.cwd});

// read and parse aliases
const txt = fs.readFileSync(tempFile, 'utf-8');
const json = txt.replace(re, '$1');
if(json){
this.allPackageAliases = <{[key: string]: PackageAliases}> JSON.parse(json) || {};
}
} catch(e: unknown){
console.log(e);
void vscode.window.showErrorMessage((<{message: string}>e).message);
} finally {
fs.rmdirSync(tempDir, {recursive: true});
}
// update persistent workspace cache
if(this.persistentState){
Expand Down