set the LANG env when rendering rmarkdown#961
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Feb 3, 2022
Merged
set the LANG env when rendering rmarkdown#961renkun-ken merged 2 commits intoREditorSupport:masterfrom
renkun-ken merged 2 commits intoREditorSupport:masterfrom
Conversation
renkun-ken
approved these changes
Feb 3, 2022
Member
renkun-ken
left a comment
There was a problem hiding this comment.
Works as expected. LGTM. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #933
The
process.envdoesn't contain the LANG environment variable. Thus, when the child process calls R, R will set the locale to "C". This causes an issue that UTF-8 strings can't be corrected handled.(If you have)Screenshot
(If you do not have screenshot) How can I check this pull request?
Open the below Rmd file in VSCode. Click the knit button to render the file. View the generated HTML file you will see:
(I only verified this on macOS and Windows. On Windows, setting the LANG won't affect the locale anyway.)