Skip to content

[data frame viewer] Add type of column to headerTooltip#974

Merged
renkun-ken merged 3 commits intoREditorSupport:masterfrom
eitsupi:dataviewer-header-tooltip
Feb 6, 2022
Merged

[data frame viewer] Add type of column to headerTooltip#974
renkun-ken merged 3 commits intoREditorSupport:masterfrom
eitsupi:dataviewer-header-tooltip

Conversation

@eitsupi
Copy link
Copy Markdown
Contributor

@eitsupi eitsupi commented Feb 6, 2022

What problem did you solve?

I was wondering if it was possible to display the column types in the data viewer.
I think it would be easier to implement and not spoil the look of the viewer if the type is displayed in the tooltip that appears when you mouse over the header.
https://www.ag-grid.com/javascript-data-grid/column-headers/#header-tooltips

Screenshot

headertooltip

It may be a little unresponsive in some cases.

Comment thread R/session/vsc.R Outdated
@renkun-ken
Copy link
Copy Markdown
Member

It may be a little unresponsive in some cases.

Using tooltipShowDelay: 100 seems to look much more responsive.

Copy link
Copy Markdown
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@eitsupi
Copy link
Copy Markdown
Contributor Author

eitsupi commented Feb 6, 2022

Thank you for the quick review and improvement!

@renkun-ken renkun-ken merged commit f7b3df0 into REditorSupport:master Feb 6, 2022
@eitsupi eitsupi deleted the dataviewer-header-tooltip branch February 6, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants