Fix getBtcBalance wrapper response#5
Conversation
|
As we discussed in #2, node.js suffers float rounding errors, therefore we decided to get and return all numbers as strings. Then we suggest that users parse those strings with some specific library, as big.js. Therefore I'm closing this PR |
|
Oops, sorry, my mistake. I forgot that the |
nicbus
left a comment
There was a problem hiding this comment.
a couple points:
- please format the code
- in
example.js, please callJSON.stringifyonbtcBalanceso it gets properly displayed
zoedberg
left a comment
There was a problem hiding this comment.
The changes look good, thanks. Please squash the commits into a single signed one, then I'll merge this
ee5dd31 to
d0bbcfb
Compare
The
wallet.getBtcBalancemethod returns the data as a string instead of an object. All similar methods do aJSON.parsebefore to return an object.This PR resolves the inconsistency by adding the missing parse