add support for P2WPKH#74
Merged
Merged
Conversation
dcorral
force-pushed
the
segwit-v0-upstream
branch
from
86648f2 to
49fb569
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 95.16% 95.19% +0.03%
==========================================
Files 23 23
Lines 11552 11628 +76
==========================================
+ Hits 10993 11069 +76
Misses 559 559
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zoedberg
requested changes
Apr 17, 2026
Member
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
Please see the requested changes. Also please rename the commit since Segwit_v0 support is imprecise, this PR is adding support for just P2WPKH, not for all segwit v0 scripts. I would rename it to add support for P2WPKH
dcorral
force-pushed
the
segwit-v0-upstream
branch
2 times, most recently
from
57776b5 to
48bfd07
Compare
zoedberg
requested changes
Apr 20, 2026
Member
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
Please address the requested changes
dcorral
force-pushed
the
segwit-v0-upstream
branch
3 times, most recently
from
58d7c25 to
900f381
Compare
zoedberg
requested changes
Apr 20, 2026
dcorral
force-pushed
the
segwit-v0-upstream
branch
3 times, most recently
from
c40e5e6 to
cb24b44
Compare
dcorral
force-pushed
the
segwit-v0-upstream
branch
from
cb24b44 to
02ac4e5
Compare
zoedberg
requested changes
Apr 20, 2026
Member
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
Please address the requested changes
dcorral
force-pushed
the
segwit-v0-upstream
branch
from
02ac4e5 to
348afa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Add P2WPKH (SegWit V0) support
Summary
ScriptTypeenum (P2wpkh/P2tr) withP2tras the default, preserving full backward compatibilityscript_typefield toWalletDatawith#[serde(default)]so existing serialized data continues to workgenerate_keys_with_script_typeandrestore_keys_with_script_typepublic API functionsScriptTypeenum andWalletData.script_typefieldBackward compatibility
ScriptTypedefaults toP2tr— existing wallets and serializedWalletDataare unaffectedgenerate_keys/restore_keysunchanged in signature and behavior#[serde(default)]onscript_typemeans JSON without the field deserializes toP2trTest check
cargo test -- segwit_v0— both P2WPKH integration tests passed