Queue Item Order Update #57
Merged
PinkSylvie merged 2 commits intomainfrom Apr 26, 2025
Merged
Conversation
Closed
PinkSylvie
requested review from
Jandel7,
edimarvalentin and
irsaris
and removed request for
Jandel7 and
edimarvalentin
irsaris
approved these changes
Apr 25, 2025
Jandel7
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is a WIP set up to be able to swap work between my PC and laptop - I don't recommend running it yet as there are a couple errors I am working on fixing.
The purpose of this branch is to add the feature to allow admins to change the order of items in the queue. This branch is also fixing a bug in which the order numbers of the queue items weren't updated when an item is deleted.
The intended UI to allow the admin user to change order is a small selection dropdown that allows the user to pick which order position they would like to place the item in.
And currently the order update bug has been fixed:
Currently working on:
Update:
Order Change Bug has been fixed and Applied Polished Order Change UI
The change is reflected in both the admin page and queue
The change is reflected in both the admin page and queue
In regards to the scheduling it seemed that the carousel used the start time to order instead of filtering which was affecting my task. I made a small change to both this and the default time in queue given to items without a given schedule. I set it for the default time for items in queue to be a day, and set the queue to filter for approved, scheduled and for items with a start_time earlier than now and an endtime later than now. As the default order is first come first served unless the queued image order is changed by an admin.