Item Reorder Rework#71
Merged
PinkSylvie merged 4 commits intomainfrom May 5, 2025
Merged
Conversation
irsaris
requested changes
May 4, 2025
Contributor
There was a problem hiding this comment.
Notes:
- Manual order change seems to work, delete works fine too.
- Schedule none override gets inserted at the end of the queue (this is fine, just a note to self).
Comments:
-
Seems like override waits until current image has finished its duration to be displayed which means its inserted after the one that is currently being displayed in the queue (which is fine). However, the use of override is for it to interrupt the current image being displayed and then place the one that was before it, after it. It used to do that, so the workflow is there; use it please, not sure where the change was made for it not to be the case anymore.
-
Also, Current Queue View (carousel in homepage) has a bug where it shows n-1 items, the item not chosen is picked at random it seems.


Contributor
|
edimarvalentin
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Due to the changes in schema queue_item does not exist anymore and the code had to be updated to take this changes into account to allow item reorder to work properly. The only changes I did where on reorder images so that it could work in a similar way as upload order worked before.
While I was at it I also added a small loop on the item delete to update the display order of the rest of the item when an item is deleated.
Item_Update
Before


After
Item_Delete


Before:
After:
Fixing Errors:
Have item titles wrap around a max-width so we dont have to limit how long a title can be. Tested it on a title with around 80 characters
