Skip to content

Item Reorder Rework#71

Merged
PinkSylvie merged 4 commits intomainfrom
item-reorder
May 5, 2025
Merged

Item Reorder Rework#71
PinkSylvie merged 4 commits intomainfrom
item-reorder

Conversation

@PinkSylvie
Copy link
Copy Markdown
Contributor

@PinkSylvie PinkSylvie commented May 3, 2025

Due to the changes in schema queue_item does not exist anymore and the code had to be updated to take this changes into account to allow item reorder to work properly. The only changes I did where on reorder images so that it could work in a similar way as upload order worked before.

While I was at it I also added a small loop on the item delete to update the display order of the rest of the item when an item is deleated.

Item_Update

Before
image
After
image

Item_Delete
Before:
image
After:
image

Fixing Errors:

Have item titles wrap around a max-width so we dont have to limit how long a title can be. Tested it on a title with around 80 characters
image

@PinkSylvie PinkSylvie self-assigned this May 3, 2025
@PinkSylvie PinkSylvie added the bug Something isn't working label May 3, 2025
@PinkSylvie PinkSylvie moved this to In Progress in RGBOARD May 3, 2025
@PinkSylvie PinkSylvie added this to the Milestone 3 milestone May 3, 2025
Copy link
Copy Markdown
Contributor

@irsaris irsaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes:

  • Manual order change seems to work, delete works fine too.
  • Schedule none override gets inserted at the end of the queue (this is fine, just a note to self).

Comments:

  1. Seems like override waits until current image has finished its duration to be displayed which means its inserted after the one that is currently being displayed in the queue (which is fine). However, the use of override is for it to interrupt the current image being displayed and then place the one that was before it, after it. It used to do that, so the workflow is there; use it please, not sure where the change was made for it not to be the case anymore.

  2. Also, Current Queue View (carousel in homepage) has a bug where it shows n-1 items, the item not chosen is picked at random it seems.
    image
    image

  3. The image cuts off if the text filename is long (add a max)
    image

@irsaris irsaris changed the base branch from restructuring-queue to main May 4, 2025 03:36
@PinkSylvie PinkSylvie requested a review from irsaris May 4, 2025 19:02
@irsaris
Copy link
Copy Markdown
Contributor

irsaris commented May 4, 2025

  1. I'll work on restoring the workflow for the override.
  2. The image cut off was only fixed for Active Queue Items (left) please do the same for Scheduled Items (right) in Manage Queue.

Copy link
Copy Markdown
Contributor

@irsaris irsaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Copy link
Copy Markdown
Contributor

@edimarvalentin edimarvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a small test and found no issues whatsoever. This feature is good to go.
image

@PinkSylvie PinkSylvie merged commit 2a7ff14 into main May 5, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in RGBOARD May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants