Skip to content

minor fixes#130

Merged
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
r2dedios:fix/renaming-review
Jul 2, 2026
Merged

minor fixes#130
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
r2dedios:fix/renaming-review

Conversation

@r2dedios

@r2dedios r2dedios commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Pack(s) affected

  • ocp-admin
  • rh-ai-engineer
  • rh-automation
  • rh-basic
  • rh-developer
  • rh-sre
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling

Contribution method

  • Created/imported with /agentic-contribution-skill
  • Manual contribution (validated with make validate + make validate-skill-design-changed)

Pack-persona alignment (new skills only)

AGENTS.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

@r2dedios
minor fixes
a67ba99 
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios r2dedios self-assigned this Jul 2, 2026
@r2dedios r2dedios added the bug Something isn't working label Jul 2, 2026
dmartinol
dmartinol reviewed Jul 2, 2026
View reviewed changes
Comment thread .gitignore Outdated
dmartinol
dmartinol reviewed Jul 2, 2026
View reviewed changes
Comment thread CLAUDE.md Outdated
dmartinol
dmartinol reviewed Jul 2, 2026
View reviewed changes
Comment thread CODEOWNERS Outdated
dmartinol
dmartinol reviewed Jul 2, 2026
View reviewed changes
Comment thread CONTRIBUTION_PROTOCOL.md Outdated
dmartinol
dmartinol reviewed Jul 2, 2026
View reviewed changes
Comment thread CONTRIBUTION_PROTOCOL.md Outdated
@r2dedios
Updated PR content with comments feedback
97f5caa 
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
dmartinol
dmartinol approved these changes Jul 2, 2026
View reviewed changes

@dmartinol dmartinol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! /lgtm

@dmartinol dmartinol merged commit e37ea6d into RHEcosystemAppEng:main Jul 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmartinol dmartinol dmartinol approved these changes
@ikrispin ikrispin Awaiting requested review from ikrispin ikrispin is a code owner
@nemerna nemerna Awaiting requested review from nemerna nemerna is a code owner

Assignees

@r2dedios r2dedios

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r2dedios @dmartinol