Skip to content

Conversation

@loganmc10
Copy link
Contributor

ImageContentSourcePolicy is deprecated since OCP 4.13[1].

This change makes it so that the operator will create the new ImageDigestMirrorSet for OCP 4.13+, while still supporting ImageContentSourcePolicy on OCP less than 4.13

[1]https://docs.openshift.com/container-platform/4.13/release_notes/ocp-4-13-release-notes.html#ocp-4-13-nodes-mirror

@loganmc10 loganmc10 self-assigned this Jun 7, 2023
@loganmc10 loganmc10 marked this pull request as draft June 7, 2023 19:41
@loganmc10 loganmc10 requested a review from danielchg June 7, 2023 22:07
@loganmc10 loganmc10 marked this pull request as ready for review June 7, 2023 22:23
@loganmc10
Copy link
Contributor Author

This is done, but I haven't tested it yet

@loganmc10
Copy link
Contributor Author

I tested this on OCP 4.12 and it still successfully creates the ImageContentSourcePolicy

Copy link
Contributor

@danielchg danielchg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielchg danielchg merged commit e01fa61 into main Jun 8, 2023
@danielchg danielchg deleted the icsp2 branch June 8, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants