Skip to content

MilvusVisor v1.5.0#15

Merged
fukai-t merged 10 commits intomainfrom
1.5.0
Apr 22, 2025
Merged

MilvusVisor v1.5.0#15
fukai-t merged 10 commits intomainfrom
1.5.0

Conversation

@PG-MANA
Copy link
Copy Markdown
Collaborator

@PG-MANA PG-MANA commented Feb 17, 2025

Changes from version 1.4.1

  • Update Rust Edition to 2024
    • Refactor by following cargo clippy
  • uefi/pxe: Add the error information
  • hypervisor_bootloader/console: Add lifetime
    • Avoid using MaybeUninit
  • hypervisor_kernel/emulation: Add EmulationError
    • Throw error reasons to the exception handler
  • hypervisor_bootloader: Fix set_up_el1
    • Move the register initializations after setting HCR_EL2
  • hypervisor_kernel: Fix multi core initialization
  • build_system: Change build system to cargo xtask from ./builder.rs
    • You can build MilvusVisor via cargo xtask build
    • bootloader and kernel can define features independently now
      • xtask parses Cargo.toml and filter the features

Waiting Issues

  • Rust Edition 2024
  • Stabilize naked_functions
    • If you want to build this branch before stabilizing this feature, please add #![features(naked_functions)] to src/hypervisor_kernel/src/main.rs

Manami Mori added 7 commits February 17, 2025 17:27
Signed-off-by: Manami Mori <manami.mori@aist.go.jp>
Signed-off-by: Manami Mori <manami.mori@aist.go.jp>
Avoid using MaybeUninit in the struct.

Signed-off-by: Manami Mori <manami.mori@aist.go.jp>
Signed-off-by: Manami Mori <manami.mori@aist.go.jp>
Signed-off-by: Manami Mori <manami.mori@aist.go.jp>
Reimplement system register copy, and
delay setting after setting HCR_EL2 due to HCR_EL2.E2H

Signed-off-by: Manami Mori <manami.mori@aist.go.jp>
Signed-off-by: Manami Mori <manami.mori@aist.go.jp>
@PG-MANA PG-MANA requested a review from fukai-t February 17, 2025 09:40
@PG-MANA PG-MANA self-assigned this Feb 17, 2025
@RIKEN-RCCS RIKEN-RCCS deleted a comment from github-actions bot Feb 17, 2025
@PG-MANA PG-MANA force-pushed the 1.5.0 branch 2 times, most recently from 7857c86 to 3f952d5 Compare February 28, 2025 12:39
`./builder.rs` uses cargo-script, which is unstable.
To stabilize the build system, this commit adds `xtask` and moved `builder.rs` to
 `xtask/src/main.rs`.

The new build system parses `Cargo.toml` to get the features list.
Therefore, `hypervisor_bootloader` and `hypervisor_kernel` feel free to
add features independently now.

Signed-off-by: Manami Mori <manami.mori@aist.go.jp>
@fukai-t
Copy link
Copy Markdown
Contributor

fukai-t commented Mar 4, 2025

@fukai-t fukai-t deleted a comment from garasubo Mar 4, 2025

@garasubo and I talked about the next release, and we confirmed that the comment is unnecessary. So I have deleted the comment.

By the way, I should add the description more about the procedure of next release because the situation of this release is special.

Manami Mori added 2 commits April 15, 2025 23:03
The previous implementation did not work.
This commit fixes to use the inherited stdio.
This commit fixes #16 .

Signed-off-by: Manami Mori <manami.mori@alum.riken.jp>
Signed-off-by: Manami Mori <manami.mori@alum.riken.jp>
@PG-MANA
Copy link
Copy Markdown
Collaborator Author

PG-MANA commented Apr 22, 2025

naked_functions will be stabilized at Rust 1.88.
Now, MilvusVisor 1.5.0 is ready to merge.

Note

Rust 1.88 will be released 2025/06/26, therefore MilvusVisor 1.5.0 still needs nightly compiler(today ~ 2025/05/15), or beta compiler(2025/05/16 ~ 2025/06/26)

@fukai-t
Copy link
Copy Markdown
Contributor

fukai-t commented Apr 22, 2025

@PG-MANA I want to confirm about the scheduled build tests. Is the following correct?

Build test with latest nightly version of Rust

The last two build tests on main branch failed because the naked_functions is stabilized in the latest nightly version of rust. This is expected results.

After merging this PR, the scheduled build test will success.

Build test with stable version of Rust

Currently, the build test failed with stable version of Rust because the stabilized naked_function has not been included in the stable version yet. The stable version of Rust including naked_function will be released on 2025/06/26 (27 or 28 in Japan?)
Until this release, the monthly build test will fail. It is also expected.

@fukai-t
Copy link
Copy Markdown
Contributor

fukai-t commented Apr 22, 2025

@PG-MANA Thank you for the response.
I will track the monthly build test by stable release of rust 1.88 on #17.

Other changes looks good to me. So I will merge this PR into main branch.

@fukai-t fukai-t merged commit 251f5a5 into main Apr 22, 2025
2 of 3 checks passed
@PG-MANA
Copy link
Copy Markdown
Collaborator Author

PG-MANA commented Apr 22, 2025

I want to confirm about the scheduled build tests. Is the following correct?
Build test with latest nightly version of Rust

Yes, the nightly build CI will success after the merge.
Note: The reason failing is not stabilizing naked_functions, but the change of the attribute style.

Build test with stable version of Rust

Yes, it is expected.
The best way is to wait the merge until the release, but it takes a long time.

@PG-MANA PG-MANA deleted the 1.5.0 branch April 22, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants