cpu/fe310: add spi peripheral driver#12957
Merged
fjmolinas merged 3 commits intoRIOT-OS:masterfrom Jan 14, 2020
Merged
Conversation
aabadie
added
Type: new feature
aabadie
added
the
State: waiting for other PR
aabadie
force-pushed
the
pr/cpu/fe310_spi
branch
from
88290d2 to
4925af4
Compare
Contributor
|
0 bytes!! 😉 |
This was referenced Dec 16, 2019
aabadie
force-pushed
the
pr/cpu/fe310_spi
branch
from
4925af4 to
a7b1b6b
Compare
aabadie
force-pushed
the
pr/cpu/fe310_spi
branch
from
a7b1b6b to
8405fbe
Compare
aabadie
added
CI: ready for build
Contributor
Author
|
rebased |
fjmolinas
reviewed
Jan 12, 2020
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
Some comments, will test on monday.
| #define UART_NUMOF ARRAY_SIZE(uart_config) | ||
| /** @} */ | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Seems like they could share the configuration file no?
Contributor
Author
There was a problem hiding this comment.
Yes and I'm planning to merge them in a common folder once all the new features are in: all other board peripheral configurations could also be shared in fact.
Contributor
There was a problem hiding this comment.
So you don't want to address here?
Contributor
Author
There was a problem hiding this comment.
Yes, otherwise, I'll have to rework all the other ones (i2c, pwm).
Comment on lines
+94
to
+95
| /* setting the CS high before configuring it as an | ||
| output should be fine on FE310. */ |
Contributor
Author
There was a problem hiding this comment.
hmm, not really, this was already implemented this way in the original PR. Maybe @pyropeter can give some insight ?
fjmolinas
reviewed
Jan 13, 2020
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
I see a conflict in the used pins with the esp module:
2020-01-13 10:01:04,699 # ATE0-->Send Flag Timed Out Busy. Giving Up.
2020-01-13 10:01:06,075 # Send Flag error: #255 #255 #255 #255 AT+BLEINIT=0-->Send Flag Timed Out Busy. Giving Up.
2020-01-13 10:01:07,451 # Send Flag error: #255 #255 #255 #255 AT+CWMODE=0-->Send Flag Timed Out Busy. Giving Up.
2020-01-13 10:01:07,455 # Send Flag error: #255 #255 #255 #255
2020-01-13 10:01:07,463 # Help: Press s to start test, r to print it is ready
Contributor
|
Test doesn't work: |
Contributor
Author
This is normal, this is the SPI that should be used to control the ESP module.
Maybe try with a simpler module, the SX127x needs several gpios to be connected to the boards (and thus requires specific driver params). |
Contributor
Ah I did not realize that. |
Contributor
It seems the ESP is getting in the way of any spi initialization, what module did you use to test this? |
Contributor
Author
|
Following the testing procedure, it works (without rebase to latest master, e.g not containing the xtimer "enhancements" from #9530): Details |
Contributor
|
Well.... layer 8 issue had forgotten o apply the patch duh: |
Contributor
Author
|
Thank you @fjmolinas ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
this PR is a rework of the original PR #10833 from @pyropeter.
It adds an implementation of the SPI peripheral driver for RISC-V FE310 cpu and configure 2 peripherals on hifive1 and hifive1b boards.
The PR was just tested with success using a bmp280 sensor plugged on the board. I'll try to find time for checking the bus with a logic analyzer.
Testing procedure
Simply plug an SPI device on the SPI pins available on the Arduino pinout and test it.
Example with bmp280:
bmpx280_params.has follows:bmp280_spiversion:Test output
Issues/PRs references
Based on #12934, closes #10833