sys/shell: always default to CONFIG_SHELL_SHUTDOWN_ON_EXIT=0 #21311
+1
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These days `native` is usually wrapped by `pyterm`. `pyterm` already takes care of handling ^D, so no need to handle this as a special case in `native`.
Member
|
I'm not quite sure I understand the benefit of this PR. Does this fix or improve anything? |
benpicco
added
the
CI: ready for build
Contributor
Author
|
The only difference is for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
These days
nativeis usually wrapped bypyterm.pytermalready takes care of handling ^D, so no need to handle this as a special case innative.Testing procedure
examples/networking/misc/telnet_serverno longer exits when you press ctrl-d on the remote shell.Issues/PRs references