drivers/at86rf215: always enable RX start IRQ after reset#22016
Open
benpicco wants to merge 1 commit intoRIOT-OS:masterfrom
Open
drivers/at86rf215: always enable RX start IRQ after reset#22016benpicco wants to merge 1 commit intoRIOT-OS:masterfrom
benpicco wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
|
Looks good. I don't have the hardware at hand, any chance someone can test? @Lennart-Lutz I guess you don't have the setup around, right? |
Contributor
|
Maybe the IRQ happens IDK. But should I not see this print that I added? switch (dev->state) {
case AT86RF215_STATE_IDLE:
if (!(bb_irq_mask & (BB_IRQ_RXFE | BB_IRQ_RXAM))) {
DEBUG("IDLE: only RXFE/RXAM expected (%x)\n", bb_irq_mask);
break;
}
if (bb_irq_mask & BB_IRQ_RXAM) {
printf("at86rf215: RX started\n");
if (netdev->event_callback) {
netdev->event_callback(netdev, NETDEV_EVENT_RX_STARTED);
}
} |
Contributor
|
Huh I see it without the fix after sleep and waking up. 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
I discovered an old bug report that RX start IRQs are not enabled again when waking from sleep - but this is easy to fix.
Testing procedure
still untested
Issues/PRs references
fixes #20505